momsse/octant
1
0
Fork 0
Code Issues 9 Pull requests 4 Projects Releases Packages Wiki Activity Actions

refactor: extract the RPC guarded(permission, action) helper into @octant/authentication #51

New issue
Closed
opened 2026-07-04 12:11:46 +00:00 by momsse · 0 comments
momsse commented 2026-07-04 12:11:46 +00:00
Owner
Copy link

Migré depuis viziertronic/octant#115 — ouvert le 2026-06-27 par @momsse.

The guarded(permission, action) helper — pipe(action, Policy.withPolicy(Policy.permission(permission))) — is now duplicated verbatim across RPC handler layers:

  • packages/domain/authorization/src/interface-adapters/rpcs/authorization.rpc.layer.ts
  • packages/domain/reconciliation/src/interface-adapters/rpcs/reconciliation.rpc.layer.ts

Each new permission-guarded RPC group copies it again. Extract it once into @octant/authentication (next to Policy) and have every RPC layer import it.

Surfaced in the #41 review (PR #114).

> _Migré depuis [viziertronic/octant#115](https://github.com/viziertronic/octant/issues/115) — ouvert le 2026-06-27 par @momsse._ The `guarded(permission, action)` helper — `pipe(action, Policy.withPolicy(Policy.permission(permission)))` — is now duplicated verbatim across RPC handler layers: - `packages/domain/authorization/src/interface-adapters/rpcs/authorization.rpc.layer.ts` - `packages/domain/reconciliation/src/interface-adapters/rpcs/reconciliation.rpc.layer.ts` Each new permission-guarded RPC group copies it again. Extract it once into `@octant/authentication` (next to `Policy`) and have every RPC layer import it. Surfaced in the #41 review (PR #114).
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
renovate/dotenv-17.x
renovate/effect
renovate/catalog-pnpm.catalog.testing
renovate/catalog-pnpm.catalog.ui
harden/145-email-change-verification
perf/bound-banking-list-rpcs
perf/bound-list-reconciliations
harden/supersede-all-established
perf/targeted-match-queries
fix/exact-match-sign-normalization
refactor/extract-rpc-guarded
fix/bank-account-sync-dedup
fix/reconciliation-document-supersession
feat/transaction-matcher-documents
feat/transaction-matcher-banking
feat/transaction-matcher-presentation
feat/compose-matcher-backend
feat/scheduling-clock-signals
feat/documents-sources-analysis
feat/banking-bank-api-sync
feat/transaction-matching
feat/postgres-reconciliation
feat/postgres-documents
feat/postgres-banking
feat/reconciliation-domain
feat/documents-domain
feat/banking-domain
worktree-glistening-hopping-tiger
split/13-backoffice
chore/treat-issue-skill
split/12-api
refacto/schema-driven-projector-writes
split/11-postgres-authorization
split/10-postgres-authentication
feat/oxlint-no-redundant-return-type
feat/observability-spans
split/09-authorization-permissions
split/08-authorization-relations
split/07-authorization-roles-groups
split/06-oauth-adapters
refactor/46-unrepresentable-errors-auth-use-cases
test/45-standardized-test-service-factories
split/05-authentication-use-cases-rpc
test/38-aggregate-state-fixtures
split/04b-user-status-value-object
crypto/37-envelope-key-id
refactor/event-sourcing-stream-cursor
feat/authentication
feat/event-sourcing-package
feat/auth-domain
auth
No results found.
Labels
Clear labels   
bug
Something isn't working

  
enhancement
New feature or request

  
pr-split
Découpage de feat/authentication en PRs reviewables

  
question
Further information is requested

  
security

   
transaction-matcher
Domaine Transaction Matcher (banking / documents / reconciliation)

No labels
bug
enhancement
pr-split
question
security
transaction-matcher
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
momsse/octant#51
No description provided.